Решение на Втора задача от Виктор Хаджипопов

Обратно към всички решения

Към профила на Виктор Хаджипопов

Резултати

  • 0 точки от тестове
  • 0 бонус точки
  • 0 точки общо
  • 0 успешни тест(а)
  • 12 неуспешни тест(а)

Код

class Collection
def initialize(songs_as_string, artist_tags)
@songs = songs_as_string.lines.inject([]) do |result, line|
parts = line.split('.')
song = Song.new(parts[0], parts[1], parts[2], parts[3])
result.push song
end
end
def find(criteria)
@songs.select{ |song| song.meet_criteria(criteria) }
end
end

Лог от изпълнението

FFFFFFFFFFFF

Failures:

  1) Collection returns all entries if called without parameters
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:37:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  2) Collection can look up songs by artist
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:41:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  3) Collection can look up songs by name
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:45:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  4) Collection uses the genre and subgenre as tags
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:100:in `song'
     # /tmp/d20111115-13548-10isa1z/spec.rb:49:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  5) Collection can find songs by tag
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:53:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  6) Collection can find songs by multiple tags
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:57:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  7) Collection can find songs that don't have a tag
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:61:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  8) Collection can filter songs by a lambda
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:65:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  9) Collection adds the artist tags to the songs
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:69:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  10) Collection allows multiple criteria
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:73:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  11) Collection allows all criteria
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:96:in `songs'
     # /tmp/d20111115-13548-10isa1z/spec.rb:82:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

  12) Collection constructs an object for each song
     Failure/Error: let(:collection) { Collection.new input, additional_tags }
     NameError:
       uninitialized constant Collection::Song
     # /tmp/d20111115-13548-10isa1z/solution.rb:5:in `block in initialize'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `lines'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `each'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `inject'
     # /tmp/d20111115-13548-10isa1z/solution.rb:3:in `initialize'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `new'
     # /tmp/d20111115-13548-10isa1z/spec.rb:34:in `block (2 levels) in <top (required)>'
     # /tmp/d20111115-13548-10isa1z/spec.rb:86:in `block (2 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (3 levels) in <top (required)>'
     # ./lib/homework/run_with_timeout.rb:5:in `block (2 levels) in <top (required)>'

Finished in 0.65856 seconds
12 examples, 12 failures

Failed examples:

rspec /tmp/d20111115-13548-10isa1z/spec.rb:36 # Collection returns all entries if called without parameters
rspec /tmp/d20111115-13548-10isa1z/spec.rb:40 # Collection can look up songs by artist
rspec /tmp/d20111115-13548-10isa1z/spec.rb:44 # Collection can look up songs by name
rspec /tmp/d20111115-13548-10isa1z/spec.rb:48 # Collection uses the genre and subgenre as tags
rspec /tmp/d20111115-13548-10isa1z/spec.rb:52 # Collection can find songs by tag
rspec /tmp/d20111115-13548-10isa1z/spec.rb:56 # Collection can find songs by multiple tags
rspec /tmp/d20111115-13548-10isa1z/spec.rb:60 # Collection can find songs that don't have a tag
rspec /tmp/d20111115-13548-10isa1z/spec.rb:64 # Collection can filter songs by a lambda
rspec /tmp/d20111115-13548-10isa1z/spec.rb:68 # Collection adds the artist tags to the songs
rspec /tmp/d20111115-13548-10isa1z/spec.rb:72 # Collection allows multiple criteria
rspec /tmp/d20111115-13548-10isa1z/spec.rb:76 # Collection allows all criteria
rspec /tmp/d20111115-13548-10isa1z/spec.rb:85 # Collection constructs an object for each song

История (1 версия и 0 коментара)

Виктор обнови решението на 31.10.2011 16:59 (преди около 13 години)

+class Collection
+ def initialize(songs_as_string, artist_tags)
+ @songs = songs_as_string.lines.inject([]) do |result, line|
+ parts = line.split('.')
+ song = Song.new(parts[0], parts[1], parts[2], parts[3])
+ result.push song
+ end
+ end
+
+ def find(criteria)
+ @songs.select{ |song| song.meet_criteria(criteria) }
+ end
+end